Fixes disarm chance calculation #5111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fira
requested changes
Dec 3, 2023
fira
approved these changes
Dec 4, 2023
Drulikar
requested changes
Dec 5, 2023
Co-authored-by: Drathek <[email protected]>
Drulikar
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
I was testing stuff out for a different PR and thought the disarm chance (for human vs human) seemed weird at times, so I forced it to output attacker_skill_level and defender_skill_level to chat every time a disarm was done. And then found out it's not calculating it properly. This seems to fix it in limited testing but might need more testing. I'm kinda surprised it wasn't noticed earlier cause there's two signs it's wrong in certain situations even with skill_level variables being invisible: the "tackled" message should only appear when the attacker's CQC level is two or higher (otherwise it should say pushed/shoved), and also, anyone that has a CQC advantage is still disarm-stunning everyone for the same amount of time as anyone else on average ('on average' because there was apparently some variance with a tick offset bug before the TG status effect testmerge) - the code implies it should be longer.
Explain why it's good for the game
Bugs should be fixed. From a balance perspective I don't know if it 'should' be fixed from what it is currently in it's bugged state... but regardless, it's a bug.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
fix: disarm chance wasn't calculating properly
/:cl: